Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pymemri pymemri
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 44
    • Issues 44
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MemriMemri
  • pymemripymemri
  • Merge requests
  • !167

Deleted item error bugfix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alp Deniz Ogut requested to merge deleted_item_bugfix into dev Feb 10, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

Client prints "Item is deleted" and raises an unhandled exception because 'item' is None. See below:

    def get(self, id, expanded=True, include_deleted=False):
        if not expanded:
            res = self._get_item_with_properties(id)
        else:
            res = self._get_item_expanded(id) ---> Error within this call
        if res is None:
            raise ValueError(f"Item with id {id} does not exist")
        elif res.deleted and not include_deleted:
            print(f"Item with id {id} has been deleted")
            return
        return res

This MR fixes this issue, however, it is not yet consistent with non-existing item behavior. (See 'raise ValueError' above) We can either choose to return None without error, or raise another 'ValueError' if item is deleted.

Considering your comments, I will change it accordingly.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: deleted_item_bugfix